Add docs on clever errors #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damirka
reviewed
Oct 31, 2024
damirka
reviewed
Oct 31, 2024
| > change due to any changes in the source file (e.g., due to auto-formatting, adding a new module | ||
| > member, or adding a newline). | ||
|
|
||
| ## Clever Abort Codes |
Collaborator
There was a problem hiding this comment.
Can you add a link to a matching page in the book/?
Contributor
Author
There was a problem hiding this comment.
We don't have one in the book/ (at least not yet) so not really anything to reference here unless I'm misunderstanding something.
tnowacki
reviewed
Nov 1, 2024
|
|
||
| ## Assertions with no Abort Codes | ||
|
|
||
| Assertions, and `abort` statements without an abort code will automatically derive an abort code |
Contributor
There was a problem hiding this comment.
Suggested change
| Assertions, and `abort` statements without an abort code will automatically derive an abort code | |
| Assertions and `abort` statements without an abort code will automatically derive an abort code |
|
|
||
| // Print the constant name (if any) | ||
| if identifier_index != 0xffff { | ||
| let constant_name = get_identifier_at_table_index(module, identifier_index); |
Contributor
There was a problem hiding this comment.
get_identifier_at_table_index
I appreciate this is pseudo code, but do we have a method for this?
Contributor
Author
There was a problem hiding this comment.
We do, but its name is not quite as descriptive as I would like here (identifier_at). I'll try and make it a bit closer, but I think having a more descriptive name here will be beneficial.
tnowacki
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds docs on clever errors.